[onert-micro] Resolve svace warning #13557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves warnings from static analysis reported by svace. Signed-off-by: Jungwoo Lee <[email protected]>
ljwoo94
commented
Jul 29, 2024
| @@ -42,7 +42,7 @@ void configure_kernel_CircleExpandDims(const circle::Operator *cur_op, | |||
| auto axis_data = runtime_graph->getConstDataByTensor(axis); | |||
| assert(axis_data != nullptr); | |||
|
|
|||
| int32_t axis_value; | |||
| int32_t axis_value = -1; | |||
There was a problem hiding this comment.
Uninitialized data is read from local variable 'axis_value' at ExpandDims.cpp:59.
ljwoo94
commented
Jul 29, 2024
| @@ -417,6 +417,7 @@ uint8_t *RuntimeGraph::getConstDataByTensor(const circle::Tensor *raw_tensor) | |||
| #endif // ENABLE_TRAINING | |||
|
|
|||
| auto const &buffer = wrap(_reader->buffers()[raw_tensor->buffer()]->data()); | |||
| assert(buffer.data() != nullptr); | |||
There was a problem hiding this comment.
a function 'luci_interpreter::RuntimeGraph::getConstDataByTensor' is dereferenced at While.cpp:110 without checking for null
ljwoo94
commented
Jul 29, 2024
| @@ -69,6 +69,7 @@ void UnpackImpl(const circle::Operator *cur_op, const circle::Tensor *input, int | |||
| const auto t = runtime_graph->getCircleTensorByIndex(output_index); | |||
| assert(output0 != nullptr); | |||
| T *output_data = kernels::getTensorData<T>(runtime_graph->getDataByTensor(t)); | |||
| assert(output_data != nullptr); | |||
There was a problem hiding this comment.
luci_interpreter::kernels::getTensorData' is dereferenced at Unpack.cpp:78 without checking for null
|
Need to be changed to if~else or throw since |
|
luci-interpreter might be deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves warnings from static analysis reported by svace.
Signed-off-by: Jungwoo Lee [email protected]